Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: add detection for complex bridge loops

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1956 bytes --]

On Saturday, March 12, 2016 10:49:33 Sven Eckelmann wrote:
> From: Simon Wunderlich <simon.wunderlich@open-mesh.com>
> 
> There are network setups where the current bridge loop avoidance can't
> detect bridge loops. The minimal setup affected would consist of two
> LANs and two separate meshes, connected in a ring like that:
> 
>    A...(mesh1)...B
>    |             |
>  (LAN1)        (LAN2)
>    |             |
>    C...(mesh2)...D
> 
> Since both the meshes and backbones are separate, the bridge loop
> avoidance has not enough information to detect and avoid the loop
> in this case. Even if these scenarios can't be fixed easily,
> these kind of loops can be detected.
> 
> This patch implements a periodic check (running every 60 seconds for
> now) which sends a broadcast frame with a random MAC address on
> each backbone VLAN. If a broadcast frame with the same MAC address
> is received shortly after on the mesh, we know that there must be a
> loop and report that incident as well as throw an uevent to let others
> handle that problem.
> 
> Signed-off-by: Simon Wunderlich <simon.wunderlich@open-mesh.com>
> [sven@narfation.org: fix conflicts with current version]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2:
>  - rebased patch
>  - fix checkpatch errors
>  - fix kernel-doc errors
> 
> Patch was resurrected from https://patchwork.open-mesh.org/patch/4154/
> 
> I've requested an rebased version at
> https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-March/014640.html
> but done it myself because it was rather trivial.
> ---
>  net/batman-adv/bridge_loop_avoidance.c | 139
> +++++++++++++++++++++++++++++++++
> net/batman-adv/main.h                  |   4 +
>  net/batman-adv/packet.h                |   1 +
>  net/batman-adv/sysfs.c                 |   6 +-
>  net/batman-adv/types.h                 |   8 ++
>  5 files changed, 156 insertions(+), 2 deletions(-)

Applied in revision a998bf5.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]