From: Sven Eckelmann <sven@narfation.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Check hard_iface refcnt before calling function
Date: Sun, 06 Mar 2016 09:55:33 +0100 [thread overview]
Message-ID: <1718376.7aKDD05sGf@sven-edge> (raw)
In-Reply-To: <20160306000823.GB1976@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
On Sunday 06 March 2016 01:08:23 Andrew Lunn wrote:
> Hi Sven
>
> Thanks for the patches. I will test them out of Monday and let you
> know if it fixes the crash.
The ones I've Cc'ed you are not really about fixing the crash. They are just
to clean up the reference counting (which you've complained about). You can
test them but I would doubt that they fix the problem. But they might help you
to detect situation when the refcounter gets 0 but shouldn't.
There are also some related problems which I've already mentioned on the
mailing list 9 months ago and never got an answer. I've moved them now to the
issue tracker in hope that the authors of the feature will now reply. The
unchecked double *_put with [2,3] together with the unchecked double list_adds
[1] are a good way to mess up the reference counting of several objects
(including the hard interfaces).
You may also want to add a real reference counting fix which I've also posted
yesterday (but for non-hard-interface objects) [4].
And a small remark about your x86 without serial port. Two systems connected
via usb-serial+null-model-cable+usb-serial work quite well for this type of
tests. Add "console=tty0 console=ttyUSB0,115200,n8" to the bootargs of your
test system and boot it up. The system used for gathering the kernel output
just has to run "screen /dev/ttyUSB0 115200" and dump all the data.
Just a suggestion in case you didn't think about using this kind of setup.
Thanks for debugging this problem and have a nice weekend.
Kind regards,
Sven
[1] https://www.open-mesh.org/issues/243
[2] https://www.open-mesh.org/issues/242
[3] https://www.open-mesh.org/issues/235
[4] https://patchwork.open-mesh.org/patch/15888/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-06 8:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 15:09 [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Check hard_iface refcnt before calling function Sven Eckelmann
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Check hard_iface refcnt when receiving skb Sven Eckelmann
2016-03-28 14:27 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: Increase hard_iface refcnt for ptype Sven Eckelmann
2016-03-31 8:58 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: Use kref_get for hard_iface subfunctions Sven Eckelmann
2016-04-11 10:13 ` Marek Lindner
2016-04-11 10:55 ` Sven Eckelmann
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: Use kref_get for batadv_tvlv_container_get Sven Eckelmann
2016-04-11 10:18 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: Use kref_get for batadv_nc_get_nc_node Sven Eckelmann
2016-04-11 10:24 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: Use kref_get for batadv_gw_select Sven Eckelmann
2016-04-11 10:25 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: Use kref_get for batadv_gw_node_add Sven Eckelmann
2016-04-11 10:29 ` Marek Lindner
2016-03-05 15:09 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: Use kref_get for _batadv_update_route Sven Eckelmann
2016-03-05 18:05 ` [B.A.T.M.A.N.] [PATCH v2 " Sven Eckelmann
2016-04-11 10:36 ` Marek Lindner
2016-03-06 0:08 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Check hard_iface refcnt before calling function Andrew Lunn
2016-03-06 8:55 ` Sven Eckelmann [this message]
2016-03-06 14:10 ` Andrew Lunn
2016-03-28 14:19 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1718376.7aKDD05sGf@sven-edge \
--to=sven@narfation.org \
--cc=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox