Re: [B.A.T.M.A.N.] [PATCH-maint 2/2] batman-adv: Only put orig_node_vlan list reference when removed

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Sunday, January 31, 2016 13:28:00 Sven Eckelmann wrote:
> The batadv_orig_node_vlan reference counter in batadv_tt_global_size_mod
> can only be reduced when the list entry was actually removed. Otherwise the
> reference counter may reach zero when batadv_tt_global_size_mod is called
> from two different contexts for the same orig_node_vlan but only one
> context is actually removing the entry from the list.
> 
> The release function for this orig_node_vlan is not called inside the
> vlan_list_lock spinlock protected region because the function
> batadv_tt_global_size_mod still holds a orig_node_vlan reference for the
> object pointer on the stack. Thus the actual release function (when
> required) will be called only at the end of the function.
> 
> Fixes: 21a57f6e7a3b ("batman-adv: make the TT CRC logic VLAN specific")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  net/batman-adv/translation-table.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied in revision ead9389.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]