Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash

[Sven Eckelmann <sven.eckelmann@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Dienstag, 20. September 2016 14:12:43 CEST Linus Lüssing wrote:
[...]
> diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
> index e79f6f0..762b34c 100644
> --- a/net/batman-adv/bat_v.c
> +++ b/net/batman-adv/bat_v.c
[...]
> +	memset(bat_v->neigh_hash, 0, sizeof(bat_v->neigh_hash));

Include <linux/string.h> is missing for it. Can you please add while
resending the patch?

[...]
> diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
> index ee08540..d4b5750 100644
> --- a/net/batman-adv/bat_v_elp.c
> +++ b/net/batman-adv/bat_v_elp.c
[...]
> +	pr_warn_once("An error occurred while calculating neighbor hash for %s\n",
> +		     hard_iface->net_dev->name);
> +}

Please include linux/printk.h for pr_warn_once.

[...]
> +int batadv_v_elp_init(void)
> +{
> +	tfm = crypto_alloc_shash("sha512", 0, 0);
> +	if (IS_ERR(tfm))
> +		return PTR_ERR(tfm);

These two require linux/err.h

[...]
>  int batadv_mesh_init(struct net_device *soft_iface)
> diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
> index 3f1c286..3a5612d 100644
> --- a/net/batman-adv/originator.c
> +++ b/net/batman-adv/originator.c
[...]
> +		if (memcmp(tmp_hardif_neigh->addr, neigh_addr, ETH_ALEN) >= 0)
> +			break;

memset requires linux/string.h

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]