From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: split routing API data structure in subobjects
Date: Fri, 06 May 2016 09:20:53 +0800 [thread overview]
Message-ID: <1779138.N065qCyhMx@voltaire> (raw)
In-Reply-To: <1462474003-25279-4-git-send-email-a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On Friday, May 06, 2016 02:46:40 Antonio Quartulli wrote:
> + .iface = {
> + .bat_activate = batadv_iv_iface_activate,
> + .bat_enable = batadv_iv_ogm_iface_enable,
> + .bat_disable = batadv_iv_ogm_iface_disable,
> + .bat_update_mac = batadv_iv_ogm_iface_update_mac,
> + .bat_primary_set = batadv_iv_ogm_primary_iface_set,
> + },
> + .neigh = {
> + .bat_cmp = batadv_iv_ogm_neigh_cmp,
> + .bat_is_similar_or_better = batadv_iv_ogm_neigh_is_sob,
> + .bat_print = batadv_iv_neigh_print,
> + },
> + .orig = {
> + .bat_print = batadv_iv_ogm_orig_print,
> + .bat_free = batadv_iv_ogm_orig_free,
> + .bat_add_if = batadv_iv_ogm_orig_add_if,
> + .bat_del_if = batadv_iv_ogm_orig_del_if,
> + },
If we are touching all API calls I suggest to remove the 'bat' prefix. For
example:
.iface = {
.activate = batadv_iv_iface_activate,
.enable = batadv_iv_ogm_iface_enable,
.disable = batadv_iv_ogm_iface_disable,
.update_mac = batadv_iv_ogm_iface_update_mac,
.primary_set = batadv_iv_ogm_primary_iface_set,
},
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-06 1:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 18:46 [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: move GW mode and selection class to private data structure Antonio Quartulli
2016-05-06 1:06 ` Marek Lindner
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: split routing API data structure in subobjects Antonio Quartulli
2016-05-06 1:10 ` Marek Lindner
2016-05-06 1:20 ` Marek Lindner [this message]
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: statically print MAX TQ value in gateway table header Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-05-05 20:17 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Sven Eckelmann
2016-05-06 2:34 ` Antonio Quartulli
2016-05-06 7:23 ` Sven Eckelmann
2016-05-06 7:53 ` Sven Eckelmann
2016-05-08 16:33 ` Antonio Quartulli
2016-05-08 16:59 ` Sven Eckelmann
2016-05-15 9:01 ` Sven Eckelmann
2016-05-06 1:03 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1779138.N065qCyhMx@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox