From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: Revert "postpone sysfs removal when unregistering"
Date: Mon, 20 Jun 2016 16:37:17 +0800 [thread overview]
Message-ID: <18126005.IvImGrenlx@voltaire> (raw)
In-Reply-To: <1465796492-5039-3-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Monday, June 13, 2016 07:41:31 Sven Eckelmann wrote:
> Postponing the removal of the interface breaks the expected behavior of
> NETDEV_UNREGISTER and NETDEV_PRE_TYPE_CHANGE. This is especially
> problematic when an interface is removed and added in quick succession.
>
> This reverts commit a33c882c1069 ("batman-adv: postpone sysfs removal when
> unregistering").
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v5:
> - rebase on top of current master
> v4:
> - rebase on top of current master
> v3:
> - rebased on top of current master to fix conflicts with newest patches
> v2:
> - rebased on top of current master to fix conflicts with newest patches
> - adjust commit message to use 12-char commit id + commit subject to
> reference
> reverted commit
> ---
> net/batman-adv/hard-interface.c | 26 +++---------------------
> net/batman-adv/soft-interface.c | 44
> ++++++++++++-----------------------------
> net/batman-adv/types.h | 4 ----
> 3 files changed, 16 insertions(+), 58 deletions(-)
Applied in revision 0994697.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-20 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 5:41 [B.A.T.M.A.N.] [PATCH v5 1/4] Revert "batman-adv: Fix hardif remove/add race" Sven Eckelmann
2016-06-13 5:41 ` [B.A.T.M.A.N.] [PATCH v5 2/4] batman-adv: Modify mesh_iface outside sysfs context Sven Eckelmann
2016-06-20 8:36 ` Marek Lindner
2016-06-13 5:41 ` [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: Revert "postpone sysfs removal when unregistering" Sven Eckelmann
2016-06-20 8:37 ` Marek Lindner [this message]
2016-06-13 5:41 ` [B.A.T.M.A.N.] [PATCH v5 4/4] batman-adv: Avoid sysfs name collision for netns moves Sven Eckelmann
2016-06-20 8:37 ` Marek Lindner
2016-06-20 8:36 ` [B.A.T.M.A.N.] [PATCH v5 1/4] Revert "batman-adv: Fix hardif remove/add race" Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18126005.IvImGrenlx@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox