Re: [PATCH] batman-adv: Use wifi rx/tx as fallback throughput

Sven Eckelmann
2019-06-09T11:09:54Z

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

On Sunday, 9 June 2019 12:19:22 CEST René Treffer wrote:
> - u32 throughput;
> + u32 throughput, rx, tx;

Avoid adding multiple variable declarations in a single line. And prefer
ordering declarations longest to shortest.

[...]
> + // try to estimate en expected throughput based on reported rx/tx rates
> + // 1/3 of tx or 1/3 of the average of rx and tx, whichever is smaller

And for the next version of the patch, please also use the same comment style
as the rest of the code [1,2].

And please explain also where the magic 1/3 comes from.

Kind regards,
Sven

[1] https://www.kernel.org/doc/html/v5.1/process/coding-style.html
[2] https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]