Re: [PATCH] batman-adv: Use wifi rx/tx as fallback throughput

Marek Lindner
2019-08-11T12:50:38Z

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

On Monday, 10 June 2019 18:06:23 HKT René Treffer wrote:
> > I also don't quite understand what the '!!!' thing is trying to indicate.
> > What is being compared ? But it may be due to my misunderstandings above.
>
> I haven't done an actual throughput test, and I would expect the outputs
> of my heuristic to be worse.
> So I wanted to give slightly lower values than the expected throughput.
>
> The other way to think about it: if you were to replace the
> expected_throughput input where would you over-estimate the link quality
> now?

Sorry, I don't follow that train of thought. Due to the lack of numbers
comparing the magic formula (tx /3) with actual throughput we (Antonio and I)
ran a few tests on ath10k devices using your patch. Surprising to us, this
approach worked quite well.

I will re-post your patch as RFC to encourage others to test the resulting
B.A.T.M.A.N. V routing decisions. If you happen to have tested more on your
end, please share your results.

Also, why considering rx on top of tx still isn't clear. Could you explain
some more ?

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]