public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] Creating alfred code documentation
@ 2016-03-12 16:12 Germano Massullo
  2016-03-12 17:55 ` Sven Eckelmann
  0 siblings, 1 reply; 4+ messages in thread
From: Germano Massullo @ 2016-03-12 16:12 UTC (permalink / raw)
  To: b.a.t.m.a.n

Hi, it's Germano from Ninux.org community.
For personal purposes, I am commenting vis.c/vis.h alfred code, at the
beginning of each function, explaining also most important local
variables (keeping in mind documentation guidelines [1])
I would like to know if you are interested in such documentation
process. If yes, I could extend this kind of work to the whole alfred
code.

Have a nice day

[1]: https://www.kernel.org/doc/Documentation/kernel-doc-nano-HOWTO.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [B.A.T.M.A.N.] Creating alfred code documentation
  2016-03-12 16:12 [B.A.T.M.A.N.] Creating alfred code documentation Germano Massullo
@ 2016-03-12 17:55 ` Sven Eckelmann
  2016-03-14 21:50   ` Germano Massullo
  2016-09-30  5:38   ` Germano Massullo
  0 siblings, 2 replies; 4+ messages in thread
From: Sven Eckelmann @ 2016-03-12 17:55 UTC (permalink / raw)
  To: b.a.t.m.a.n

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

On Saturday 12 March 2016 17:12:19 Germano Massullo wrote:
> Hi, it's Germano from Ninux.org community.
> For personal purposes, I am commenting vis.c/vis.h alfred code, at the
> beginning of each function, explaining also most important local
> variables (keeping in mind documentation guidelines [1])
> I would like to know if you are interested in such documentation
> process. If yes, I could extend this kind of work to the whole alfred
> code.

Sounds great. I am currently not sure about the "explaining also most
important local variables" part but maybe you just do the vis.c/.h and then
submit it as patch(es) [1]. This way we can discuss it on an actual example
before you crawl through the complete alfred(-vis|-gpsd) codebase.

Kind regards,
	Sven

[1] https://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [B.A.T.M.A.N.] Creating alfred code documentation
  2016-03-12 17:55 ` Sven Eckelmann
@ 2016-03-14 21:50   ` Germano Massullo
  2016-09-30  5:38   ` Germano Massullo
  1 sibling, 0 replies; 4+ messages in thread
From: Germano Massullo @ 2016-03-14 21:50 UTC (permalink / raw)
  To: Sven Eckelmann, b.a.t.m.a.n


[-- Attachment #1.1: Type: text/plain, Size: 531 bytes --]

Il 12/03/2016 18:55, Sven Eckelmann ha scritto:
> I am currently not sure about the "explaining also most important
> local variables" 

For example in the function

=========

static int vis_read_answer(struct globals *globals)
{
	const struct vis_print_ops *ops;
	struct vis_v1 *vis_data;
	uint16_t len;
	struct vis_iface *ifaces;
	struct vis_entry *vis_entries;
// CUT


=========
I would stress the purposes description of
struct vis_v1 *vis_data
struct vis_iface *ifaces
struct vis_entry *vis_entries


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [B.A.T.M.A.N.] Creating alfred code documentation
  2016-03-12 17:55 ` Sven Eckelmann
  2016-03-14 21:50   ` Germano Massullo
@ 2016-09-30  5:38   ` Germano Massullo
  1 sibling, 0 replies; 4+ messages in thread
From: Germano Massullo @ 2016-09-30  5:38 UTC (permalink / raw)
  To: Sven Eckelmann, b.a.t.m.a.n

Hi, I want to tell that I have not forgotten the task, but I have been
very busy during past months :-)
I think to resume the work in autumn :-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-30  5:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-12 16:12 [B.A.T.M.A.N.] Creating alfred code documentation Germano Massullo
2016-03-12 17:55 ` Sven Eckelmann
2016-03-14 21:50   ` Germano Massullo
2016-09-30  5:38   ` Germano Massullo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox