From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@open-mesh.com>,
Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 1/4] batman-adv: don't switch byte order too often if not needed
Date: Mon, 14 Oct 2013 19:07:57 +0800 [thread overview]
Message-ID: <1821487.crxj1At65v@diderot> (raw)
In-Reply-To: <1381625420-4062-2-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Sunday 13 October 2013 02:50:17 Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
>
> If possible, operations like ntohs/ntohl should not be
> performed too often. Use a variable to locally store the
> converted value and then use it.
>
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
> routing.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Applied in revision 60087ff (master branch).
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-10-14 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 0:50 [B.A.T.M.A.N.] [PATCHv2 0/4] Introduce the SYNCHRONIZED TT flags Antonio Quartulli
2013-10-13 0:50 ` [B.A.T.M.A.N.] [PATCHv2 1/4] batman-adv: don't switch byte order too often if not needed Antonio Quartulli
2013-10-13 9:44 ` Marek Lindner
2013-10-13 9:51 ` Antonio Quartulli
2013-10-14 11:07 ` Marek Lindner [this message]
2013-10-13 0:50 ` [B.A.T.M.A.N.] [PATCHv2 2/4] batman-adv: invoke dev_get_by_index() outside of is_wifi_iface() Antonio Quartulli
2013-10-14 13:20 ` Marek Lindner
2013-10-13 0:50 ` [B.A.T.M.A.N.] [PATCHv2 3/4] batman-adv: improve the TT component to support runtime flag changes Antonio Quartulli
2013-10-14 11:22 ` Marek Lindner
2013-10-13 0:50 ` [B.A.T.M.A.N.] [PATCHv2 4/4] batman-adv: include the synch-flags when compute the global/local table CRC Antonio Quartulli
2013-10-14 14:37 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1821487.crxj1At65v@diderot \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=antonio@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox