From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: avoid double free when orig_node initialization fails
Date: Sat, 15 Feb 2014 09:27:59 +0800 [thread overview]
Message-ID: <1821645.R5sTtn65FM@diderot> (raw)
In-Reply-To: <1392427040-1614-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Saturday 15 February 2014 02:17:20 Antonio Quartulli wrote:
> In the failure path of the orig_node initialization routine
> the orig_node->bat_iv.bcast_own field is free'd twice: first
> in batadv_iv_ogm_orig_get() and then later in
> batadv_orig_node_free_rcu().
>
> Fix it by removing the kfree in batadv_iv_ogm_orig_get().
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>
> Change form v1:
> - remove kfree from batadv_iv_ogm_orig_get() instead of setting
> orig_node->bat_iv.bcast_own to NULL
>
>
> bat_iv_ogm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied in revision d4acda1.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2014-02-15 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 1:17 [B.A.T.M.A.N.] [PATCHv2] batman-adv: avoid double free when orig_node initialization fails Antonio Quartulli
2014-02-15 1:27 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1821645.R5sTtn65FM@diderot \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox