[B.A.T.M.A.N.] [PATCH] batman-adv: fix lock class for decoding hash in network-coding.c

[B.A.T.M.A.N.] [PATCH] batman-adv: fix lock class for decoding hash in network-coding.c

[Martin Hundebøll]

batadv_has_set_lock_class() is called with the wrong hash table as first
argument (probably due to a copy-paste error), which leads to false
positives when running with lockdep.

Introduced-by: 612d2b4fe0a1ff2f8389462a6f8be34e54124c05
('batman-adv: network coding - save overheard and tx packets for decoding')

Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
---
 network-coding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/network-coding.c b/network-coding.c
index bd33894..127cc4d 100644
--- a/network-coding.c
+++ b/network-coding.c
@@ -133,7 +133,7 @@ int batadv_nc_mesh_init(struct batadv_priv *bat_priv)
 	if (!bat_priv->nc.decoding_hash)
 		goto err;
 
-	batadv_hash_set_lock_class(bat_priv->nc.coding_hash,
+	batadv_hash_set_lock_class(bat_priv->nc.decoding_hash,
 				   &batadv_nc_decoding_hash_lock_class_key);
 
 	INIT_DELAYED_WORK(&bat_priv->nc.work, batadv_nc_worker);
-- 
2.1.3

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix lock class for decoding hash in network-coding.c

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Tuesday 11 November 2014 16:22:23 Martin Hundebøll wrote:
> batadv_has_set_lock_class() is called with the wrong hash table as first
> argument (probably due to a copy-paste error), which leads to false
> positives when running with lockdep.
> 
> Introduced-by: 612d2b4fe0a1ff2f8389462a6f8be34e54124c05
> ('batman-adv: network coding - save overheard and tx packets for decoding')
> 
> Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
> ---
>  network-coding.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged in revision e7ba36c.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]