From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix change mac address of soft iface.
Date: Tue, 18 Sep 2012 16:55:32 +0200 [thread overview]
Message-ID: <1860743.fUGhpHrPxd@bentobox> (raw)
In-Reply-To: <CANMkaozByUVfK9h_UAY08UDCZd6xJWg7NqPpCTWJfsyaBnEJEA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Tuesday 18 September 2012 16:41:58 Def wrote:
> Into function interface_set_mac_addr, the function tt_local_add
> was invoked before updating dev->dev_addr. The new MAC
> addresse was not tagged as NoPurge.
>
Please don't add extra whitespaces before your commit message.
Your Signed-off-by: is missing.
[...]
> -
> - memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
> +
Please don't add trailing whitespaces.
I have no idea whether this works... *looks at Antonio*. But thanks for
bringing this up in the issue tracker and sending this first version of the
patch.
The problems mentioned here can be found using
checkpatch/cppcheck/sparse/smatch [1]. We need to drop this patch due to these
problems because the next authorities (David S. Miller/Linus Torvalds/...)
would not be happy when we forward them this version of the patch.
Kind regards,
Sven
[1] http://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-18 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:41 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix change mac address of soft iface Def
2012-09-18 14:55 ` Sven Eckelmann [this message]
2012-09-20 11:42 ` Antonio Quartulli
2012-09-20 12:56 ` [B.A.T.M.A.N.] [PATCHv2] " Def
2012-09-20 18:10 ` Antonio Quartulli
2012-09-23 8:42 ` Sven Eckelmann
2012-09-23 9:34 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1860743.fUGhpHrPxd@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox