public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [v3] Add throughput meter support
Date: Tue, 03 May 2016 10:59:07 +0200	[thread overview]
Message-ID: <1894217.a7ufKNXfSr@bentobox> (raw)

[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]

Hi,

here is the third version of the throughput meter support. It is just a
rebased version of the patchset with two little bugfixes. Both problems were
detected and reported by Antonio:

 * batctl didn't check if the test_time is > 0 before doing a division
 * batman-adv wasn't returning an error to batctl when dst was not reachable


I am currently unsure how we should proceed regarding the ICMP packet type
used to communicate to the userspace ([PATCH 2/3]). Andrew+Matthias already
prepared a netlink patchset which looks quite good and which should be
tested+applied. The consequence for this patchset would be that patch 2 should
be completely dropped and instead the tp_meter should become its own command
in the netlink interface of batman-adv. Any opinions about that (order in
which patches should be applied/netlink interface should be handled) by the
Simon, Antonio, Marek, Matthias or Andrew?


Antonio Quartulli (4):
      batman-adv: return netdev status in the TX path
      batman-adv: use another ICMP packet when sending command from userspace
      batman-adv: throughput meter implementation
      batctl: introduce throughput meter support

 net/batman-adv/Makefile         |    1 +
 net/batman-adv/fragmentation.c  |   41 +-
 net/batman-adv/fragmentation.h  |    6 +-
 net/batman-adv/icmp_socket.c    |  225 +++---
 net/batman-adv/icmp_socket.h    |    5 +-
 net/batman-adv/main.c           |    6 +-
 net/batman-adv/main.h           |   24 +-
 net/batman-adv/packet.h         |  120 ++++
 net/batman-adv/routing.c        |   33 +-
 net/batman-adv/send.c           |   25 +-
 net/batman-adv/soft-interface.c |    2 +
 net/batman-adv/tp_meter.c       | 1453 +++++++++++++++++++++++++++++++++++++++
 net/batman-adv/tp_meter.h       |   34 +
 net/batman-adv/types.h          |  113 +++
 14 files changed, 1944 insertions(+), 144 deletions(-)

 Makefile     |   2 +-
 main.c       |   6 ++
 main.h       |   1 +
 man/batctl.8 |  24 +++++-
 packet.h     | 120 ++++++++++++++++++++++++++++++
 tcpdump.c    |  14 +++-
 tp_meter.c   | 236 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tp_meter.h   |  22 ++++++
 8 files changed, 421 insertions(+), 4 deletions(-)


Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2016-05-03  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  8:59 Sven Eckelmann [this message]
2016-05-03  9:00 ` [B.A.T.M.A.N.] [PATCH v3 2/3] batman-adv: use another ICMP packet when sending command from userspace Sven Eckelmann
2016-05-03  9:00 ` [B.A.T.M.A.N.] [PATCH v3 3/3] batman-adv: throughput meter implementation Sven Eckelmann
2016-05-03  9:01 ` [B.A.T.M.A.N.] [PATCH v3] batctl: introduce throughput meter support Sven Eckelmann
2016-05-03 12:28 ` [B.A.T.M.A.N.] [v3] Add " Simon Wunderlich
2016-05-03 12:32   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1894217.a7ufKNXfSr@bentobox \
    --to=sven.eckelmann@open-mesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox