From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sven@narfation.org>
From: Sven Eckelmann <sven@narfation.org>
Date: Wed, 06 Jul 2016 08:12:09 +0200
Message-ID: <1937144.keiqMBNOt5@sven-edge>
In-Reply-To: <20160706024929.GA25250@lkp-nex05>
References: <201607061025.fb3YfL1g%fengguang.wu@intel.com>
 <20160706024929.GA25250@lkp-nex05>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2142932.Evm1nDiLWN";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix boolreturn.cocci warnings
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Antonio Quartulli <a@unstable.cc>, kbuild-all@01.org, b.a.t.m.a.n@lists.open-mesh.org, Marek Lindner <mareklindner@neomailbox.ch>

--nextPart2142932.Evm1nDiLWN
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Wednesday 06 July 2016 10:49:29 kbuild test robot wrote:
> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> CC: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---

Reviewed-by: Sven Eckelmann <sven@narfation.org>

The problematic commit is in batman-adv.git (next):

Fixes: a998bf5dfbd7 ("batman-adv: add detection for complex bridge loops")

And in net-next.git (due to some reordering)

Fixes: 4b426b108ac8 ("batman-adv: Use bool as return type for boolean functions")


Thanks,
	Sven
> 
>  bridge_loop_avoidance.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/net/batman-adv/bridge_loop_avoidance.c
> +++ b/net/batman-adv/bridge_loop_avoidance.c
> @@ -1102,7 +1102,7 @@ static bool batadv_bla_process_claim(str
>  
>  	/* Let the loopdetect frames on the mesh in any case. */
>  	if (bla_dst->type == BATADV_CLAIM_TYPE_LOOPDETECT)
> -		return 0;
> +		return false;
>  
>  	/* check if it is a claim frame. */
>  	ret = batadv_check_claim_group(bat_priv, primary_if, hw_src, hw_dst,

--nextPart2142932.Evm1nDiLWN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCgAGBQJXfKE5AAoJEF2HCgfBJntGm/QQAIsGp5H2ZKCE4Kw4P6NbVmlA
ONcuL9s22q1wDn8usB8tmanqEwdonBQ58QQWFM6Y3bxdZHRFfF3OpgFy3Gggf1MQ
CCp64cdjfBEDKmLPRgnExs3uFtoH9Y0QqXujMZe9jxl3NG6dP9fRBgMxrSbZdzMG
psgLzeOmTk4xWJt0gqm94lBEGb4VF1009MlxckRJevgc0/yEN8yHvWxS/vHOGFyn
kEqGl3GaVuAnUSGbuQAAKZU0XiDYHTQYkJIX/v3mnsGjqgBTVDIw7oy25oXG6OYs
HJkPGiU/6smSYEAp1fgRC9q97YQLaTA5gPur/IAvGVO1y2aZLIgv3Gq2XcmNY3rY
nyrc/iZWXlAsJlw8HinLc1Zi/3L+nHkV8LIVBhT6UNhgj8yHLu5Cz0anUgmxayiu
3x0PSSth1FtGbMIVCvtF3W4/fNQzsxu9fNzFNZBK+UWuFwI1P83QCN1Bng2nrsx6
1oRZbrD23Ay3iY3RVbVSCuc49TcXDx9TSGtRRsf2IDzfFsN/bx7Po9M9xff29SU+
4E8GMUVF4S1UhptuX4CfrbtIU+bKYuFUHHVuZKQcekPfslMM0WtTx8WzJHnlA8CP
1rJ7+vXV2OroyRnYLK/3D7IhwzBiDnJb+P+lU4ypE2bQBx5lJbwfu8TVAYGypjZI
FFjt0jHsgyOWJPvsnO/7
=Kzw/
-----END PGP SIGNATURE-----

--nextPart2142932.Evm1nDiLWN--