From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Allow setting the source mac via unix sock
Date: Fri, 11 Mar 2016 16:27:11 +0100 [thread overview]
Message-ID: <1940763.5sKtNKt5OI@prime> (raw)
In-Reply-To: <56C44D11.3000706@heidler.eu>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Wednesday 17 February 2016 11:36:01 Dominik Heidler wrote:
> Am 17.02.2016 um 09:39 schrieb Sven Eckelmann:
> > Your patch also doesn't explain why this feature may be required.
>
> I'm running an alfred master server with this patch, so that I can run a
> script that will inject data of legacy clients (that don't have an alfred
> slave, but need to be crawled).
Sorry for the late reply. In generally I think this change is acceptable,
however I'd like to request the following changes and to resend your patch:
* Please write a proper commit message in the patch, explaining your scenario
and why you need it
* Write a comment above the change you made to explain that clients should
set the mac to 00:00:00:00:00:00 by default, unless they want alfred to use
its mac for them.
Thank you!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-11 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 23:51 [B.A.T.M.A.N.] [PATCH] alfred: Allow setting the source mac via unix sock Dominik Heidler
2016-02-17 8:10 ` Sven Eckelmann
2016-02-17 8:39 ` Sven Eckelmann
2016-02-17 10:36 ` Dominik Heidler
2016-03-11 15:27 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1940763.5sKtNKt5OI@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox