From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: move and restructure batadv_v_ogm_forward
Date: Sat, 30 Jan 2016 12:35:33 +0800 [thread overview]
Message-ID: <1947926.p5gVdyYhcU@voltaire> (raw)
In-Reply-To: <1453296735-8319-1-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]
On Wednesday, January 20, 2016 14:32:14 Simon Wunderlich wrote:
> /**
> - * batadv_v_ogm_forward - forward an OGM to the given outgoing interface
> + * batadv_v_ogm_forward - check conditions and forward an OGM to the given
> + * outgoing interface
> * @bat_priv: the bat priv with all the soft interface information
> * @ogm_received: previously received OGM to be forwarded
> - * @throughput: throughput to announce, may vary per outgoing interface
> + * @neigh_node: the neigh_node through with the OGM has been received
> * @if_incoming: the interface on which this OGM was received on
> * @if_outgoing: the interface to which the OGM has to be forwarded to
> *
> @@ -359,28 +360,55 @@ static u32 batadv_v_forward_penalty(struct batadv_priv
> *bat_priv, */
> static void batadv_v_ogm_forward(struct batadv_priv *bat_priv,
> const struct batadv_ogm2_packet *ogm_received,
> - u32 throughput,
> + struct batadv_neigh_node *neigh_node,
> struct batadv_hard_iface *if_incoming,
> struct batadv_hard_iface *if_outgoing)
> {
> + struct batadv_neigh_ifinfo *neigh_ifinfo = NULL;
> + struct batadv_orig_ifinfo *orig_ifinfo = NULL;
> + struct batadv_neigh_node *router = NULL;
> struct batadv_ogm2_packet *ogm_forward;
> unsigned char *skb_buff;
> struct sk_buff *skb;
> size_t packet_len;
> u16 tvlv_len;
>
> + /* only forward for specific interfaces, not for the default one. */
> + if (if_outgoing != BATADV_IF_DEFAULT)
> + goto out;
> +
> + orig_ifinfo = batadv_orig_ifinfo_new(orig_node, if_outgoing);
The variable 'orig_node' isn't defined anywhere in the context of this
function. It was passed as an argument to batadv_v_ogm_route_update().
Please recompile with 'make CONFIG_BATMAN_ADV_BATMAN_V=y' and fix all errors
and warnings. :-)
> + if (!orig_ifinfo)
> + goto out;
> + /* acquire possibly updated router */
> + router = batadv_orig_router_get(orig_node, if_outgoing);
A new line between the goto and the comment would be nice to have.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-01-30 4:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 13:32 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: move and restructure batadv_v_ogm_forward Simon Wunderlich
2016-01-20 13:32 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Merge batadv_v_ogm_orig_update into batadv_v_ogm_route_update Simon Wunderlich
2016-01-20 14:34 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: move and restructure batadv_v_ogm_forward Antonio Quartulli
2016-01-20 15:18 ` Simon Wunderlich
2016-01-20 15:26 ` Antonio Quartulli
2016-01-20 15:29 ` Antonio Quartulli
2016-01-20 15:48 ` Simon Wunderlich
2016-01-20 15:31 ` Simon Wunderlich
2016-01-30 4:35 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1947926.p5gVdyYhcU@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox