From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection
Date: Tue, 31 May 2016 19:57:37 +0200 [thread overview]
Message-ID: <1971303.VRszsITxlU@bentobox> (raw)
In-Reply-To: <56E2BCD8.9010200@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Friday 11 March 2016 13:40:56 SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 11 Mar 2016 13:10:20 +0100
>
> The variables "tt_local_entry" and "tt_global_entry" were eventually
> checked again despite of a corresponding null pointer test before.
>
> * Avoid this double check by reordering a function call sequence
> and the better selection of jump targets.
>
> * Omit the initialisation for these variables at the beginning then.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Reviewed-by: Sven Eckelmann <sven@narfation.org>
See
* https://www.kernel.org/doc/Documentation/SubmittingPatches
Chapter 7: Centralized exiting of functions
* https://plus.google.com/106378716002406849458/posts/dnanfhQ4mHQ
* http://article.gmane.org/gmane.linux.documentation/28552
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-31 17:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.sourceforge.net>
2015-11-03 20:45 ` [B.A.T.M.A.N.] [PATCH 0/3] batman-adv: Deletion of a few unnecessary checks SF Markus Elfring
2015-11-03 20:52 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Delete an unnecessary check before the function call "batadv_softif_vlan_free_ref" SF Markus Elfring
2015-11-21 21:48 ` Marek Lindner
2015-11-03 20:54 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Split a condition check SF Markus Elfring
2015-11-21 21:51 ` Marek Lindner
2015-11-03 20:56 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection SF Markus Elfring
2015-11-20 8:47 ` Antonio Quartulli
2015-11-20 10:56 ` SF Markus Elfring
2016-03-10 19:30 ` Sven Eckelmann
2016-03-11 12:40 ` [B.A.T.M.A.N.] [PATCH] " SF Markus Elfring
2016-03-14 19:25 ` David Miller
2016-03-15 0:14 ` Antonio Quartulli
2016-05-31 17:57 ` Sven Eckelmann [this message]
2016-10-18 12:44 ` [B.A.T.M.A.N.] " Sven Eckelmann
2015-11-15 8:40 ` [B.A.T.M.A.N.] [PATCH 0/2] batman-adv: Deletion of some unnecessary checks SF Markus Elfring
2015-11-15 8:43 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Delete unnecessary checks before the function call "kfree_skb" SF Markus Elfring
2015-11-21 21:45 ` Marek Lindner
2015-11-15 8:45 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Less checks in batadv_tvlv_unicast_send() SF Markus Elfring
2015-11-21 21:47 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1971303.VRszsITxlU@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox