Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Initialize memory for station_info

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

On Mittwoch, 6. Juni 2018 06:44:32 CEST Antonio Quartulli wrote:
[...]
> This looks fairly reasonable and at a first glance I can confirm that
> even ieee80211_get_station() does not clear it up before filling it.
> 
> However, what do you think about zero'ing the sinfo object directly in
> cfg80211_get_station()?
> I think it is safe to assume that no user should store anything in this
> object before passing it to get_station().

I understand your point. But there is the potential problem that such a change 
requires more discussion with the Johannes/other wireless guys - while the 
early B.A.T.M.A.N. V adopters still suffer under this problem. I will ask him 
in IRC first about his opinion but send a second version of the patch to the 
batman-adv mailing list. We can later decide which route we take.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]