public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] Out of tree builds of kernel modules
Date: Sat, 11 Apr 2009 06:34:39 +0800	[thread overview]
Message-ID: <200904110634.39509.lindner_marek@yahoo.de> (raw)
In-Reply-To: <200904101231.14877.sven.eckelmann@gmx.de>


Hi,

> First thing is that there is a Makefile.kbuild which is included with
>  include $(PWD)/Makefile.kbuild
> This will not work in the current situation because the PWD is now
> /usr/src/linux-headers-2.6.29-1-amd64. Is this extra Makefile.kbuild really
> needed?

the Makefile.kbuild was introduced to support OpenWRT better (OpenWRT uses the 
kbuild Makefile only and replaces the main Makefile with its own). Could we do 
the same with debian ?


>  KERNELPATH ?= /lib/modules/$(shell uname -r)/build
>  # sanity check: does KERNELPATH exist?
>  ifeq ($(shell cd $(KERNELPATH) && pwd),)
>  $(warning $(KERNELPATH) is missing, please set KERNELPATH)
>  endif
>
> ok too?

Yes, I think its fine. I commited it.


> The batmand-gateway cannot be build for linux 2.6 if the current kernel is
> a 2.4.x. Isn't it possible to make the obj-m and batgat-objs assignment
> outside the check for the kernel version?

I'm not so sure what you have in mind. Could you explain it further ?


> My current workaround is to install my own version of the Makefile in the
> debian package, but I ask myself if this is really needed or parts of it
> should also be changed upstream.

I think we should try to move as much as possible upstream in order to reduce 
the overhead of the package maintainers.

Regards,
Marek



  reply	other threads:[~2009-04-10 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 10:31 [B.A.T.M.A.N.] Out of tree builds of kernel modules Sven Eckelmann
2009-04-10 22:34 ` Marek Lindner [this message]
2009-04-11  8:53   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200904110634.39509.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@open-mesh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox