Re: [B.A.T.M.A.N.] [batman-adv] bitarray.[ch] Linux coding style cleanup

[Andrew Lunn <andrew.lunn@ascom.ch>]

On Tue, Jul 14, 2009 at 03:09:26PM +0200, Andrew Lunn wrote:
> Fix all the warnings generated by the 2.6.29 checkpatch script about
> violations of the Linux coding style in the bitarray.[ch]
> files.

This patch is to probe the waters a little. Marek has said off the
list that it has been decided that the batman-adv code should conform
to the Linux kernel coding standard. Much of the code is currently
not! What i dislike most in the current code base is the long
lines. The coding style says that lines should be less than 80
characters long. 

This patch cleans up two files, making them pass the coding style
checks for 2.6.29, the latest kernel code i have hanging around on my
machine.

What are peoples opinion about this? Should i spend a little time
cleaning up all the files? Some code needs refactoring a little, to
reducing the nesting, creating more helper functions, but mostly its
white space changes. However such changes can cause pain when trying
to merge in other work people who diff's are against before the
cleanup. Does anybody have any major patches?

         Thanks
                  Andrew