From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [batman-adv] Cleanup aggregation.[ch]
Date: Thu, 23 Jul 2009 19:59:29 +0800 [thread overview]
Message-ID: <200907231959.55861.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20090718143250.GI4656@ma.tech.ascom.ch>
On Saturday 18 July 2009 22:32:50 Andrew Lunn wrote:
> Make aggregation.[ch] clean with respect to the 2.6.29 checkpatch script.
>
> Signed-off-by: Andrew Lunn <andrew.lunn@ascom.ch>
I applied your patch.
I noticed you created a function for the calculcation of the hna length. It
does not really do much. Would it make sense to transform it into a macro ?
While reviewing the code I saw multiple incarnations of the variable
own_packet. Sometimes it is char, uint8_t or int. Not sure what effect it might
have but I think it would be better to unify that ?!
Regards,
Marek
next prev parent reply other threads:[~2009-07-23 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 14:32 [B.A.T.M.A.N.] [batman-adv] Cleanup aggregation.[ch] Andrew Lunn
2009-07-23 11:59 ` Marek Lindner [this message]
2009-07-23 13:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907231959.55861.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox