From: Andrew Lunn <andrew.lunn@ascom.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [batman-adv] Cleanup proc.[ch]
Date: Thu, 30 Jul 2009 20:40:00 +0200 [thread overview]
Message-ID: <20090730184000.GA3396@ma.tech.ascom.ch> (raw)
In-Reply-To: <200907251950.58372.lindner_marek@yahoo.de>
On Sat, Jul 25, 2009 at 07:50:55PM +0800, Marek Lindner wrote:
> On Saturday 18 July 2009 22:52:36 Andrew Lunn wrote:
> > Make proc.[ch] clean with respect to the 2.6.29 checkpatch
> > script. Exceptions are long lines with printk/seq_print.
>
> I just applied this patch with a small modification. You changed the vis output
> from float link quality to integer. This removes valuable information and I
> don't see why this is necessary, hence I changed it back. May be I overlooked
> something - please let us know the reasoning behind this.
Upps, sorry. That was an error. We have a graphing tool which uses
both vis and originators. This changed made them both use the same
units for link quality. That is nice for your tool, but probably not
wanted for other people.
Andrew
prev parent reply other threads:[~2009-07-30 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-18 14:52 [B.A.T.M.A.N.] [batman-adv] Cleanup proc.[ch] Andrew Lunn
2009-07-25 11:50 ` Marek Lindner
2009-07-30 18:40 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730184000.GA3396@ma.tech.ascom.ch \
--to=andrew.lunn@ascom.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox