From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: [B.A.T.M.A.N.] Breaking long lines...
Date: Wed, 26 Aug 2009 12:47:06 +0200 [thread overview]
Message-ID: <20090826104706.GG20818@lunn.ch> (raw)
In-Reply-To: <200908261651.16980.lindner_marek@yahoo.de>
> > I found also some other things and also told that Marek - but I think that
> > not everything was included in the patch I send some weeks ago. Maybe it
> > was only to break printk statements to fit in 80 chars per line, but I am
> > not sure right now.
>
> Yes, you found a way to break a long string into smaller pieces although I
> can't quite remember how you did it. ;-)
ANSI C/C++ allows:
"foor"
"bar"
and the compiler will glue the parts back together as "foobar".
However, i often don't like the resulting code layout. I also think
there might be a bug in checkpatch. The relevant code is:
#80 column limit
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
$line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
$length > 80)
{
WARN("line over 80 characters\n" . $herecurr);
}
my perl is not good, but it appears to be looking for KERN_, eg
KERN_ERR, KERN_WARNING etc, and maybe should be ignoring such lines?
Andrew
next prev parent reply other threads:[~2009-08-26 10:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 6:41 [B.A.T.M.A.N.] List policy for none subscribers Andrew Lunn
2009-08-26 7:54 ` Marek Lindner
2009-08-26 8:27 ` Andrew Lunn
2009-08-26 8:01 ` Sven Eckelmann
2009-08-26 8:51 ` Marek Lindner
2009-08-26 10:47 ` Andrew Lunn [this message]
2009-08-26 10:52 ` [B.A.T.M.A.N.] New name for batman-adv? Andrew Lunn
2009-08-27 9:58 ` Marek Lindner
2009-08-27 19:44 ` Andrew Lunn
2009-08-28 1:57 ` Outback Dingo
2009-08-28 3:08 ` Andrew de Andrade
2009-08-28 6:42 ` Antoine van Gelder
2009-10-09 18:57 ` Linus Lüssing
2009-08-26 11:01 ` [B.A.T.M.A.N.] Configuration interface Andrew Lunn
2009-08-27 13:57 ` [B.A.T.M.A.N.] List policy for none subscribers Bernd Petrovitsch
2009-08-26 9:19 ` elektra
2009-08-26 10:41 ` Andrew Lunn
2009-08-26 18:08 ` Andrew Lunn
2009-08-27 10:05 ` Marek Lindner
2009-08-27 11:10 ` elektra
2009-08-27 14:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826104706.GG20818@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox