From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] Updating orig_str for debug
Date: Thu, 3 Dec 2009 10:48:17 +0800 [thread overview]
Message-ID: <200912031048.17909.lindner_marek@yahoo.de> (raw)
In-Reply-To: <4B172691.8010707@gmail.com>
Hi Gus,
> Shouldn't the "addr_to_string(orig_str, orig_node->orig);" be moved out
> side the loop to near the top of the function? There is only one
> originator node and there is no reason to iterate over it. One time
> should suffice.
you are probably right but I know that Andrew has a patch in his pipeline
which will remove these addr_to_string() calls entirely (printk can handle mac
addresses for us). Until then we can live with this workaround. :)
Regards,
Marek
next prev parent reply other threads:[~2009-12-03 2:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 0:24 [B.A.T.M.A.N.] [PATCH] Updating orig_str for debug Linus Lüssing
2009-12-03 2:45 ` Marek Lindner
2009-12-03 2:46 ` Gus Wirth
2009-12-03 2:48 ` Marek Lindner [this message]
2009-12-03 5:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912031048.17909.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox