public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context
Date: Thu, 17 Dec 2009 13:25:44 +0100	[thread overview]
Message-ID: <20091217122544.GM4648@lunn.ch> (raw)
In-Reply-To: <1261051915-13960-1-git-send-email-sven.eckelmann@gmx.de>

Hi Sven

This reminds me of something i keep intending to do, but never get
around to.

It would be nice to have a LOCKING.TXT document, with the following
Table of Contents.

1) What locks we have and what they protect.

2) What different contexts different parts of the code run in.

These two sections provide the basis for the following sections.

3) Which locking primitives, ie spin_lock() or spin_lock_irqsave()
should be used for each lock.

4) A list of what order locks should be taken in, when taking multiple
locks, so as to avoid deadlocks.

When finding this bug, did you take any notes etc, which could
contribute to such a document?

	   Thanks
		Andrew

  reply	other threads:[~2009-12-17 12:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17 12:11 [B.A.T.M.A.N.] [PATCH] batman-adv: Use forw_bcast_list_lock always in disabled interrupt context Sven Eckelmann
2009-12-17 12:25 ` Andrew Lunn [this message]
2009-12-17 14:34   ` Sven Eckelmann
2009-12-17 14:47     ` Sven Eckelmann
2009-12-17 13:11 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217122544.GM4648@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox