From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres
Date: Thu, 31 Dec 2009 11:56:52 +0100 [thread overview]
Message-ID: <20091231105652.GJ8143@lunn.ch> (raw)
In-Reply-To: <20091213190149.GA22421@pandem0nium>
On Sun, Dec 13, 2009 at 08:01:49PM +0100, Simon Wunderlich wrote:
> Hello Andrew,
>
> i've checked your patch against older kernel, and there seem to be some
> compile problems. E.g. compiling against 2.6.26, i find:
>
> CC [M] /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.o
> /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c: In function ???pointer???:
> /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c:564: error: implicit declaration of function ???dereference_function_descriptor???
> /home/dotslash/msrc/batman-svn/batman-adv-kernelland/bat_printk.c:564: warning: assignment makes pointer from integer without a cast
>
> against 2.6.21, there are a lot more lines of warnings and errors, while
> 2.6.20 works mostly fine. Could you please review your patch in this regard?
> I have nearly all kernels installed so i can give you a list of compile logs if you
> are interested.
Hi Simon
I just posted an updated version of the patch. It would be great if
you could test it on a few different kernels. I tried
2.6.21. bat_printk.c now compiles, but other parts of batman-adv fail.
I think it was your skbuff patches which broke it, but i could be
wrong.
Andrew
prev parent reply other threads:[~2009-12-31 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 21:42 [B.A.T.M.A.N.] [patchv2] batman-adv: Use printk(%pM) for MAC addres Andrew Lunn
2009-12-13 19:01 ` Simon Wunderlich
2009-12-31 10:56 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091231105652.GJ8143@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox