From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality
Date: Mon, 18 Jan 2010 16:24:26 +0100 [thread overview]
Message-ID: <20100118152426.GG7844@lunn.ch> (raw)
In-Reply-To: <20100118151552.GE7844@lunn.ch>
> CHECK /home/lunn/batman/trunk/batman-adv-kernelland/gateway_common.c
> /home/lunn/batman/trunk/batman-adv-kernelland/gateway_common.c:28:6: warning: symbol 'kbit_to_gw_srv_class' was not declared. Should it be static?
> CHECK /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c
> /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c:27:1: warning: symbol 'gw_list' was not declared. Should it be static?
> /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c:28:1: warning: symbol 'curr_gw_lock' was not declared. Should it be static?
> /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c:29:1: warning: symbol 'gw_list_lock' was not declared. Should it be static?
> /home/lunn/batman/trunk/batman-adv-kernelland/gateway_client.c:227:6: warning: context imbalance in 'gw_node_update' - wrong count at exit
Ah, just took a closer look. These are probably from Marek, not
Simon.
gw_node_update() is missing a rcu_read_unlock(); before the return
inside the list_for_each_entry_rcu() loop. The others are less
serious, but should be corrected as well.
Andrew
next prev parent reply other threads:[~2010-01-18 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 18:27 [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality Simon Wunderlich
2010-01-17 20:15 ` Simon Wunderlich
2010-01-18 11:31 ` Marek Lindner
2010-01-18 15:15 ` Andrew Lunn
2010-01-18 15:24 ` Andrew Lunn [this message]
2010-01-19 0:12 ` Marek Lindner
2010-01-19 17:44 ` Andrew Lunn
2010-01-18 22:57 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118152426.GG7844@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox