Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality

Andrew Lunn
2010-01-19T17:44:17Z

On Tue, Jan 19, 2010 at 08:12:49AM +0800, Marek Lindner wrote:
> On Monday 18 January 2010 23:24:26 Andrew Lunn wrote:
> > gw_node_update() is missing a rcu_read_unlock(); before the return
> > inside the list_for_each_entry_rcu() loop. The others are less
> > serious, but should be corrected as well.
>
> Thanks - I just fixed it.
>
> What does this error message want to tell us ?
> batman-adv-kernelland/routing.c:966:5: warning: context imbalance in
> 'recv_unicast_packet' - different lock contexts for basic block

I've never spent the time to read the sparse documentation to figure
out exactly what this means. Just from experience i know it is trying
to tell us the locks don't balance in some code path. ie the number of
locks don't equal the number of unlocks. It is not the friendliest of
warning messages.

Andrew