Re: [B.A.T.M.A.N.] slowpath warning

Simon Wunderlich
2010-03-02T21:13:24Z

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

Hello Andrew,

no, sorry, and i won't be able to do it this week as i am at the cebit
this whole week (if anyone else is there, please tell me. ;).

I would therefore like to ask you and Linus to test it as well, i will
perform more tests on sunday.

Thanks,
Simon

On Tue, Mar 02, 2010 at 07:43:08AM +0100, Andrew Lunn wrote:
> On Mon, Mar 01, 2010 at 05:57:06PM +0100, Simon Wunderlich wrote:
> > Hey Andrew,
> >
> > all list-adds and list-removes do a kref_get or kref_put respectively,
> > but that probably was not very clear. As soon as a refence is created
> > (by linking into the hash or a list), we should also kref_get() it.
> >
> > Please find attached a new version of this patch with separate
> > send_list_add/remove functions which include the put/get functions.
> > I've also added the kref_put/get call to the send_list loop again.
> > It should look more balanced now. Tested in my 9 qemu setup again,
> > no memory leaks or crashes but i only did a very quick test
> > (15 minutes)
>
> Hi Simon
>
> This looks better. Did it survive longer testing?
>
> Andrew
>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]