Re: [B.A.T.M.A.N.] slowpath warning

Linus Lüssing
2010-02-19T17:19:05Z

[-- Attachment #1: Type: text/plain, Size: 3065 bytes --]

Hi Andrew,

Sorry, didn't have the time to try your patch any earlier, I'm
right in the middle of my exams :).
Your patch already looks quite good, I couldn't reproduce any
memory leaks or crashes here (tried that with three routers and 1
or 2 vis servers activated, also activating/deactivating them a
lot, no problems with that). And yes, the slow-path warning has
gone with your patch.
However, I'm having some weird output when connecting two routers
over wifi _and_ over ethernet cable. The setup:

Before plugging in the cable:
r1-ath1 <-- wifi --> r2-ath1
------------
root@OpenWrt:~# batctl vd dot
digraph {
"r1-ath1" -> "r2-ath1" [label="1.32"]
"r1-ath1" -> "r1-hna" [label="HNA"]
"r1-ath1" -> "5a:2e:1e:1f:64:6b" [label="HNA"]
subgraph "cluster_r1-ath1" {
"r1-ath1" [peripheries=2]
}
"r2-ath1" -> "r1-ath1" [label="1.11"]
"r2-ath1" -> "r2-hna" [label="HNA"]
"r2-ath1" -> "82:31:95:f9:14:6f" [label="HNA"]
subgraph "cluster_r2-ath1" {
"r2-ath1" [peripheries=2]
}
}
------------
After plugging in the cable:
r1-ath1 <-- wifi --> r2-ath1 +
r1-eth0.3 <-- cable --> r2-eth0.3
------------
root@OpenWrt:~# batctl vd dot
digraph {
"r1-ath1" -> "r2-ath1" [label="1.0"]
"r1-ath1" -> "r2-eth0.3" [label="1.66"]
"r1-ath1" -> "r1-hna" [label="HNA"]
"r1-ath1" -> "5a:2e:1e:1f:64:6b" [label="HNA"]
subgraph "cluster_r1-ath1" {
"r1-ath1" [peripheries=2]
"r1-eth0.3"
}
subgraph "cluster_r1-ath1" {
"r1-ath1" [peripheries=2]
}
"r2-ath1" -> "r1-ath1" [label="1.0"]
"r2-ath1" -> "r1-eth0.3" [label="1.15"]
"r2-ath1" -> "r2-hna" [label="HNA"]
"r2-ath1" -> "82:31:95:f9:14:6f" [label="HNA"]
subgraph "cluster_r2-ath1" {
"r2-ath1" [peripheries=2]
"r2-eth0.3"
}
subgraph "cluster_r2-ath1" {
"r2-ath1" [peripheries=2]
}
}
root@OpenWrt:~# cat /proc/net/batman-adv/vis_data
06:22:b0:98:87:dd,TQ 04:22:b0:98:87:fa 251, HNA 00:22:b0:98:87:dd, HNA 5a:2e:1e:1f:64:6b, PRIMARY, SEC 04:22:b0:98:87:de,
06:22:b0:98:87:f9,TQ 06:22:b0:98:87:dd 255, TQ 04:22:b0:98:87:de 251, HNA 00:22:b0:98:87:f9, HNA 82:31:95:f9:14:6f, SEC 04:22:b0:98:87:fa, PRIMARY,
----------
So the second 'subgraph "cluster_r1-ath1"' is obviously
unnecessary. Also "r1-ath1" -> "r2-eth0.3" looks wrong, should be
"r1-eth0.3" -> "r2-eth0.3" instead (and the same with r2 a few
lines later).

Cheers, Linus

On Thu, Feb 11, 2010 at 11:01:56AM +0100, Andrew Lunn wrote:
> On Thu, Feb 11, 2010 at 10:46:59AM +0100, Andrew Lunn wrote:
> > Hi Linus
> >
> > Here is a new version of the patch. I've tested it this time using
> > five UML machines. It should not immediately opps now.
>
> Instead is will leak memory and crash after a while...
>
> I will try to find the memory leak.
>
> Andrew
>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]