Re: [B.A.T.M.A.N.] slowpath warning

Marek Lindner
2010-01-28T00:09:57Z

Hi,

> nope, does not seem to work, still the same issue
> I also tried it on my laptop here with the patch installed
> and it is a very similar call trace, although here it is
> send_vis_packets instead of vis_quit in the call trace.

you should take the stack trace with a grain of salt. Stack tracing such an
issue is a quite tricky thing, hence can not be fully trusted. Since the skb
changes the code runs in interrupt context which probably introduced this bug.
All previous warnings of this kind were related to holding a lock while
sending packets. My patch unlocked the problematic orig_hash - maybe that was
not enough ? By adding retrun statements at the beginning of the vis send
function you might be able to get down to the problem.

Regards,
Marek