[B.A.T.M.A.N.] FWD: batman: potential null dereference

[Andrew Lunn <andrew@lunn.ch>]

Does somebody have time to look at this?

     Andrew

----- Forwarded message from Dan Carpenter <error27@gmail.com> -----

Date: Mon, 8 Mar 2010 16:07:01 +0300
From: Dan Carpenter <error27@gmail.com>
To: andrew@lunn.ch
Cc: kernel-janitors@vger.kernel.org
Subject: batman: potential null dereference
X-Spam-Status: No, score=2.9 required=4.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB autolearn=no
	version=3.3.0

drivers/staging/batman-adv/routing.c
    88          } else if ((orig_node->router == NULL) && (neigh_node != NULL)) {
                            ^^^^^^^^^^^^^^^^^^^^^^^^^
    89  
    90                  bat_dbg(DBG_ROUTES,
    91                          "Adding route towards: %pM (via %pM)\n",
    92                          orig_node->orig, neigh_node->addr);
    93                  hna_global_add_orig(orig_node, hna_buff, hna_buff_len);
    94  
    95                  /* route changed */
    96          } else {
    97                  bat_dbg(DBG_ROUTES, "Changing route towards: %pM (now via %pM - was via %pM)\n", 
orig_node->orig, neigh_node->addr, orig_node->router->addr);
                                   ^^^^^^^^^^^^^^^^^^^^^^^									
    98          }

This could fail if debugging is enabled and neigh_node is null.

regards,
dan carpenter

----- End forwarded message -----