Re: [B.A.T.M.A.N.] reorganized kernel interface patches (version 2)

["Linus Lüssing" <linus.luessing@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Hi Marek,

those patches look quite good to me now, seems to work here as
expected.
Just one note: One of those warnings has gone now with the
_GNU_SOURCE stuff. However, getline is also being used in
funcitions.c:174 (so adding the define to functions.c too, got rid
of the second warning for instance).

Cheers, Linus

On Wed, Mar 03, 2010 at 06:40:15AM +0800, Marek Lindner wrote:
> 
> Hi,
> 
> I merged the feedback given so far into the patchset and post them again to 
> offer you the chance of generating even more feedback.  :-)
> 
> Changes since version1:
> * the known issue from version1 turned out to be a bug in the used kernel
> * batctl sysfs path has been changed to /sys/class/net/ since older kernels 
> don't provide the "virtual" subdirectory
> * the year of the copyright notice was corrected
> * In case the erroneous of input contains a newline it will not be printed to 
> avoid printing 2 subsequent newlines
> * the function calls which used global variables before now receive the 
> bat_priv struct as an argument
> * added _GNU_SOURCE to bat-hosts.c to avoid compile warning
> * batctl gets bonding mode support
> 
> Cheers,
> Marek
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]