public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Clone shared bat packets before modifying them
Date: Mon, 15 Mar 2010 01:52:35 +0800	[thread overview]
Message-ID: <201003150152.35548.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1268586955-29220-1-git-send-email-sven.eckelmann@gmx.de>

On Monday 15 March 2010 01:15:55 Sven Eckelmann wrote:
> "tcpdump" and "batctl td" will receive packets with a wrong sequence
> number on systems with a different endianess than network byte order.
> This happens due to the reordering of bytes in the function which
> handles aggregated bat packets. The function which receives the bat
> packets must ensure that these buffers aren't shared with anything else
> before that function tries to write into it. Otherwise it has to copy
> the buffers so it is save again to change them.

Applied in rev 1598.

Thanks for this quick fix!

Cheers,
Marek

  reply	other threads:[~2010-03-14 17:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14  0:35 [B.A.T.M.A.N.] Strange sequence numbers Kevin Steen
2010-03-14  0:52 ` Kevin Steen
2010-03-14 12:04 ` Sven Eckelmann
2010-03-14 15:50   ` Sven Eckelmann
2010-03-14 17:08     ` [B.A.T.M.A.N.] [PATCH] batman-adv: Clone shared bat packets before modifying them Sven Eckelmann
2010-03-14 17:15     ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
2010-03-14 17:52       ` Marek Lindner [this message]
2010-03-14 19:33       ` Kevin Steen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003150152.35548.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox