Re: [B.A.T.M.A.N.] [PATCH] 32bit sequence number and TTL for broadcasts

[Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>]

[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]

Hello Sven,

thank you for your review. I've compiled and tested it in my openwrt qemu 
build environment, which is built on linux 2.6.31.1.

I have not checked it on any other platforms so far.

best regards,
	Simon

On Sun, Apr 25, 2010 at 10:48:13PM +0200, Sven Eckelmann wrote:
> First thing: it doesn't compile here :( (UML), but I am quite unsure if this 
> is a UML problem like many other things or a bigger problem.... it seems that 
> it is uml specific as ATOMIC64_INIT and other thingss are defined, but the 
> implementation of specific functions are missing... but this is not the first 
> time such thing happens with uml. Maybe someone with some time can check 
> different openwrt builds.
> 
> For example other architecture seems to use the generic implementation of it:
>  * arm
>  * parisc
>  * powerpc
>  * sh
> 
> UML in contrast uses a x86 specific header for it, but doesn't compile the 
> actual lib/atomic64_32.c file
> 
> I will check if this is maybe gone with a never version of linux (still 
> running 2.6.32 in my uml), but the rest looks fine to me.
> 
> By the way, on which platforms have you checked it? I've just noticed another 
> problem with copied skbs which prevents the discovery of other nodes - not 
> specific to that commit. I haven't finished the debugging of that problem and 
> will change the wireshark dissector before doing that.
> 
> Best regards,
> 	Sven



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]