public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "B.A.T.M.A.N" <b.a.t.m.a.n@lists.open-mesh.net>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: [B.A.T.M.A.N.] maint tree mixup...
Date: Fri, 30 Apr 2010 19:52:35 +0200	[thread overview]
Message-ID: <20100430175235.GH3734@lunn.ch> (raw)

Hi Folks

It could be i'm doing something stupid here. If so, please tell me...

I'm preparing a patchset for linux. I've run into some problems.
You can see the patches to be included here:

http://git.open-mesh.org/?p=batman-adv;a=shortlog;h=refs/heads/maint

The one which is causing me problems is:

2010-03-20 Marek Lindner batman-adv: fix aggregation timing bug

When i add this patch and then try to compile i get:

drivers/staging/batman-adv/aggregation.c:207:35: error: undefined identifier 'bat_priv'

the code being:

                    (atomic_read(&bat_priv->aggregation_enabled)))

However, if you look at the patch:

2010-04-06 Marek Lindner batman-adv: convert multiple /proc files to use sysfs

which comes about 16 days later you see:

--- a/types.h
+++ b/types.h
@@ -82,6 +82,8 @@ struct neigh_node {
 

 struct bat_priv {
        struct net_device_stats stats;
+       atomic_t aggregation_enabled;
+       struct kobject *mesh_obj;
 };

So it looks to me these patches have got out of order.....

Any ideas what happened?

    Thanks
	Andrew

             reply	other threads:[~2010-04-30 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 17:52 Andrew Lunn [this message]
2010-04-30 17:59 ` [B.A.T.M.A.N.] maint tree mixup Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100430175235.GH3734@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.net \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=lindner_marek@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox