public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] maint tree mixup...
@ 2010-04-30 17:52 Andrew Lunn
  2010-04-30 17:59 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2010-04-30 17:52 UTC (permalink / raw)
  To: B.A.T.M.A.N; +Cc: Marek Lindner

Hi Folks

It could be i'm doing something stupid here. If so, please tell me...

I'm preparing a patchset for linux. I've run into some problems.
You can see the patches to be included here:

http://git.open-mesh.org/?p=batman-adv;a=shortlog;h=refs/heads/maint

The one which is causing me problems is:

2010-03-20 Marek Lindner batman-adv: fix aggregation timing bug

When i add this patch and then try to compile i get:

drivers/staging/batman-adv/aggregation.c:207:35: error: undefined identifier 'bat_priv'

the code being:

                    (atomic_read(&bat_priv->aggregation_enabled)))

However, if you look at the patch:

2010-04-06 Marek Lindner batman-adv: convert multiple /proc files to use sysfs

which comes about 16 days later you see:

--- a/types.h
+++ b/types.h
@@ -82,6 +82,8 @@ struct neigh_node {
 

 struct bat_priv {
        struct net_device_stats stats;
+       atomic_t aggregation_enabled;
+       struct kobject *mesh_obj;
 };

So it looks to me these patches have got out of order.....

Any ideas what happened?

    Thanks
	Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [B.A.T.M.A.N.] maint tree mixup...
  2010-04-30 17:52 [B.A.T.M.A.N.] maint tree mixup Andrew Lunn
@ 2010-04-30 17:59 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2010-04-30 17:59 UTC (permalink / raw)
  To: The list for a Better Approach To Mobile Ad-hoc Networking; +Cc: Marek Lindner

On Fri, Apr 30, 2010 at 07:52:35PM +0200, Andrew Lunn wrote:
> Hi Folks
> 
> It could be i'm doing something stupid here. If so, please tell me...

Found the problem/fix. The next patch in the sequence repairs the
damage.

I just need to squash the two patches together any everything will be
good.

	Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-30 17:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-30 17:52 [B.A.T.M.A.N.] maint tree mixup Andrew Lunn
2010-04-30 17:59 ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox