From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: lindner_marek@yahoo.de, b.a.t.m.a.n@lists.open-mesh.net
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Import sparse fixes from mainline.
Date: Sat, 1 May 2010 18:34:56 +0200 [thread overview]
Message-ID: <201005011837.42615.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <1272719410-406-3-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: Text/Plain, Size: 1242 bytes --]
Andrew Lunn wrote:
> diff --git a/bat_sysfs.c b/bat_sysfs.c
> index 7acf8d8..e2c000b 100644
> --- a/bat_sysfs.c
> +++ b/bat_sysfs.c
> @@ -357,7 +357,8 @@ void sysfs_del_meshif(struct net_device *dev)
> static ssize_t show_mesh_iface(struct kobject *kobj, struct attribute
> *attr, char *buff)
> {
> - struct net_device *net_dev = to_net_dev(to_dev(kobj->parent));
> + struct device *dev = to_dev(kobj->parent);
> + struct net_device *net_dev = to_net_dev(dev);
> struct batman_if *batman_if = get_batman_if_by_netdev(net_dev);
This has not real something to do with this patch (which is good), but
to_net_dev was added in v2.6.20-236-g43cb76d and the README still states that
we are compatible with linux 2.6.20. I think we must change that to 2.6.25
(explanation below).
I did a build test with 2.6.19-2.6.28 (have to update my buildenv...):
* 2.6.19: fails in many ways
* 2.6.20: fails in bat_sys.c
* 2.6.21: warnings in bat_sys.c (better call it fail)
* 2.6.22: warnings in bat_sys.c (better call it fail)
* 2.6.23: fails
* 2.6.24: fails
* 2.6.25: ok
* 2.6.26: ok
* 2.6.27: ok
* 2.6.28: ok
But to your patch:
Acked-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-05-01 16:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 13:10 [B.A.T.M.A.N.] [PATCH 0/4] *** SUBJECT HERE *** Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Update README to match mainline README Andrew Lunn
2010-05-01 13:53 ` Sven Eckelmann
2010-05-01 14:26 ` Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Import sparse fixes from mainline Andrew Lunn
2010-05-01 16:34 ` Sven Eckelmann [this message]
2010-05-01 16:48 ` Andrew Lunn
2010-05-01 17:13 ` Marek Lindner
2010-05-01 18:10 ` Sven Eckelmann
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: whitespace " Andrew Lunn
2010-05-01 13:33 ` Sven Eckelmann
2010-05-01 13:46 ` [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: send.c: Checkpatch cleanup Sven Eckelmann
2010-05-01 14:12 ` Andrew Lunn
2010-05-01 14:10 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: whitespace fixes from mainline Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit Andrew Lunn
2010-05-01 13:28 ` Sven Eckelmann
2010-05-01 14:05 ` Andrew Lunn
2010-05-01 17:14 ` [B.A.T.M.A.N.] [PATCH 0/4] *** SUBJECT HERE *** Marek Lindner
2010-05-01 18:17 ` Andrew Lunn
2010-05-01 18:56 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005011837.42615.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox