* [B.A.T.M.A.N.] [PATCH] batman-adv: remove all rcu head initializations
[not found] <1273868969293@kroah.org>
@ 2010-05-16 13:02 ` Sven Eckelmann
2010-05-17 9:58 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
0 siblings, 1 reply; 3+ messages in thread
From: Sven Eckelmann @ 2010-05-16 13:02 UTC (permalink / raw)
To: b.a.t.m.a.n
From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Remove all rcu head inits. We don't care about the RCU head state before
passing it to call_rcu() anyway. Only leave the "on_stack" variants so
debugobjects can keep track of objects on stack.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
I've tried to check if the initialisation was always done in call_rcu in all
implementations since 2.6.21. This assumption seems to be correct. I've
already applied it to the maint branch and it must only be applied to the
trunk.
hard-interface.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hard-interface.c b/hard-interface.c
index c17ad85..bc2bd12 100644
--- a/hard-interface.c
+++ b/hard-interface.c
@@ -341,7 +341,6 @@ static struct batman_if *hardif_add_interface(struct net_device *net_dev)
batman_if->if_num = -1;
batman_if->net_dev = net_dev;
batman_if->if_status = IF_NOT_IN_USE;
- INIT_RCU_HEAD(&batman_if->rcu);
INIT_LIST_HEAD(&batman_if->list);
check_known_mac_addr(batman_if->net_dev->dev_addr);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [B.A.T.M.A.N.] [PATCHv2] batman-adv: remove all rcu head initializations
2010-05-16 13:02 ` [B.A.T.M.A.N.] [PATCH] batman-adv: remove all rcu head initializations Sven Eckelmann
@ 2010-05-17 9:58 ` Sven Eckelmann
2010-05-17 13:58 ` Marek Lindner
0 siblings, 1 reply; 3+ messages in thread
From: Sven Eckelmann @ 2010-05-17 9:58 UTC (permalink / raw)
To: b.a.t.m.a.n
From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Remove all rcu head inits. We don't care about the RCU head state before
passing it to call_rcu() anyway. Only leave the "on_stack" variants so
debugobjects can keep track of objects on stack.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
I've tried to check if the initialisation was always done in call_rcu in all
implementations since 2.6.21. This assumption seems to be correct. I've
already applied it to the maint branch and it must only be applied to the
trunk.
v2: I've accidently send the version of maint instead the version for trunk.
There were no real differences, but the paths.
batman-adv-kernelland/hard-interface.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/batman-adv-kernelland/hard-interface.c b/batman-adv-kernelland/hard-interface.c
index 5123176..cc7fbae 100644
--- a/batman-adv-kernelland/hard-interface.c
+++ b/batman-adv-kernelland/hard-interface.c
@@ -341,7 +341,6 @@ static struct batman_if *hardif_add_interface(struct net_device *net_dev)
batman_if->if_num = -1;
batman_if->net_dev = net_dev;
batman_if->if_status = IF_NOT_IN_USE;
- INIT_RCU_HEAD(&batman_if->rcu);
INIT_LIST_HEAD(&batman_if->list);
check_known_mac_addr(batman_if->net_dev->dev_addr);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: remove all rcu head initializations
2010-05-17 9:58 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
@ 2010-05-17 13:58 ` Marek Lindner
0 siblings, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2010-05-17 13:58 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Monday 17 May 2010 17:58:50 Sven Eckelmann wrote:
> From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> Remove all rcu head inits. We don't care about the RCU head state before
> passing it to call_rcu() anyway. Only leave the "on_stack" variants so
> debugobjects can keep track of objects on stack.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
> Cc: Marek Lindner <lindner_marek@yahoo.de>
> Cc: Sven Eckelmann <sven.eckelmann@gmx.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Ok, applied in revision 1659.
Thanks,
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-17 13:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1273868969293@kroah.org>
2010-05-16 13:02 ` [B.A.T.M.A.N.] [PATCH] batman-adv: remove all rcu head initializations Sven Eckelmann
2010-05-17 9:58 ` [B.A.T.M.A.N.] [PATCHv2] " Sven Eckelmann
2010-05-17 13:58 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox