From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] Converting from /dev to debugfs
Date: Tue, 18 May 2010 22:35:14 +0200 [thread overview]
Message-ID: <201005182235.22328.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201005171951.21349.sven.eckelmann@gmx.de>
[-- Attachment #1: Type: Text/Plain, Size: 1222 bytes --]
Sven Eckelmann wrote:
> Unfortunately I am not able to continue it today, but don't want to stop
> other people working on similar things. I will attach v0 (aka works for
> me, but maybe not perfect/good enough) versions of these patches to
> support them. Please feel free to discuss the patches.
I converted the remaining files from sysfs to debugfs, but I noticed that
there is a problem with the output functions (see "BUG" comments in patch 3).
The problem is that we may sleep during the prints in the output functions,
but we disabled interrupts.... which is bad. This problem was also their
before we converted from /proc to /sys. It seems that it was first introduced
in r1517. The old way for hna_global_fill_buffer_text
hna_local_fill_buffer_text solved it, but restricted the output to 4096 bytes.
So we could either stay with a "slow" and maybe inconsistent output or
restricted output length or copy the data to a local buffer and then creating
the output without spinlock or something completely different.
The patches are for trunk, but I would provide backported versions when the
patches are discussed and we could solve the problem in a sane way.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-05-18 20:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 17:51 [B.A.T.M.A.N.] Converting from /dev to debugfs Sven Eckelmann
2010-05-17 17:52 ` [B.A.T.M.A.N.] [PATCHv0 1/2] batman-adv: Move device for icmp injection " Sven Eckelmann
2010-05-17 17:52 ` [B.A.T.M.A.N.] [PATCHv0 2/2] batctl: Use socket in debugfs instead of batman-adv device Sven Eckelmann
2010-05-18 20:35 ` Sven Eckelmann [this message]
2010-05-18 20:37 ` [B.A.T.M.A.N.] [PATCHv1 1/4] batman-adv: Move device for icmp injection to debugfs Sven Eckelmann
2010-05-18 20:37 ` [B.A.T.M.A.N.] [PATCHv1 2/4] batctl: Use socket in debugfs instead of batman-adv device Sven Eckelmann
2010-05-18 20:37 ` [B.A.T.M.A.N.] [PATCHv1 3/4] batman-adv: Move tables from sysfs to debugfs Sven Eckelmann
2010-05-18 20:45 ` [B.A.T.M.A.N.] [PATCHv2 " Sven Eckelmann
2010-05-19 17:40 ` [B.A.T.M.A.N.] [PATCHv3 " Sven Eckelmann
2010-05-18 20:37 ` [B.A.T.M.A.N.] [PATCHv1 4/4] batctl: Get tables from debugfs instead of sysfs Sven Eckelmann
2010-05-21 15:25 ` [B.A.T.M.A.N.] Converting from /dev to debugfs Marek Lindner
2010-05-19 19:41 ` [B.A.T.M.A.N.] Converting to sysfs - maint versions Sven Eckelmann
2010-05-19 19:43 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Move device for icmp injection to debugfs Sven Eckelmann
2010-05-19 19:43 ` [B.A.T.M.A.N.] [PATCH 2/4] batctl: Use socket in debugfs instead of batman-adv device Sven Eckelmann
2010-05-19 19:43 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Move tables from sysfs to debugfs Sven Eckelmann
2010-05-19 19:43 ` [B.A.T.M.A.N.] [PATCH 4/4] batctl: Get tables from debugfs instead of sysfs Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005182235.22328.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox