From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Correct mdev calculation in ping subcommand
Date: Thu, 20 May 2010 19:00:01 +0200 [thread overview]
Message-ID: <201005201900.01910.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201005201851.54709.sven.eckelmann@gmx.de>
[-- Attachment #1: Type: Text/Plain, Size: 927 bytes --]
Sven Eckelmann wrote:
> Daniel Seither wrote:
> > Fixes the calculation of the mean absolute deviation (mdev)
> > of the roundtrip times. mdev was previously calculated by
> > computing the difference of maximum and minimum round trip times.
> >
> > The calculation is now done using the same formula as in the iputils
> > ping program.
> >
> > Signed-off-by: Daniel Seither <post@tiwoc.de>
>
> Acked-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Ok, have a small suggestion. Please check that mdev - ... is positive.
Otherwise we would have something like (mdev - avg * avg == -0.000.....,
sqrt(...) == NaN):
PING 02:00:00:00:00:02 (02:00:00:00:00:02) 19(47) bytes of data
19 bytes from 02:00:00:00:00:02 icmp_seq=1 ttl=50 time=0.10 ms
--- 02:00:00:00:00:02 ping statistics ---
1 packets transmitted, 1 received, 0% packet loss
rtt min/avg/max/mdev = 0.101/0.101/0.101/nan ms
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-05-20 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 16:29 [B.A.T.M.A.N.] [PATCHv2] batctl: Correct mdev calculation in ping subcommand Daniel Seither
2010-05-20 16:51 ` Sven Eckelmann
2010-05-20 17:00 ` Sven Eckelmann [this message]
2010-05-20 17:58 ` Daniel Seither
2010-05-20 18:06 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005201900.01910.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox