Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use rx_handler_data pointer to store net_bridge_port pointer

Sven Eckelmann
2010-06-17T07:25:57Z

[-- Attachment #1: Type: Text/Plain, Size: 734 bytes --]

Andrew Lunn wrote:
> > --- a/batman-adv-kernelland/hard-interface.h
> > +++ b/batman-adv-kernelland/hard-interface.h
> > @@ -38,3 +38,8 @@ int batman_skb_recv(struct sk_buff *skb,
> >
> > struct net_device *orig_dev);
> >
> > int hardif_min_mtu(void);
> > void update_min_mtu(void);
> >
> > +
> > +#ifndef netdev_isbridged
> > +#define netdev_isbridged(netdev) \
> > + ((net_dev)->priv_flags & IFF_BRIDGE_PORT)
> > +#endif
>
> Maybe this could be pushed upstream? Seems like a useful bit of code
> in general?

I don't think so. It is only used in ~7 places in the whole kernel. If you
want then please feel free to add something like this and submit it to David
S. Miller.

Best regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]