From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <lindner_marek@yahoo.de>, b.a.t.m.a.n@lists.open-mesh.net
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs
Date: Wed, 23 Jun 2010 17:23:59 +0200 [thread overview]
Message-ID: <20100623152359.GL15420@lunn.ch> (raw)
In-Reply-To: <1277302839-20197-1-git-send-email-lindner_marek@yahoo.de>
On Wed, Jun 23, 2010 at 04:20:38PM +0200, Marek Lindner wrote:
Hi Marek
> - if (bat_debug_type(type)) \
> - printk(KERN_DEBUG "batman-adv:" fmt, ## arg); \
did you think about keeping this? Maybe use some of the spare bits of
debug to indicate what goes into the circular buffer and what goes to
the kernel log?
I don't see the two schemes are mutually exclusive. "Normal" kernel
hackers will look in the normal kernel logging places and could be a
bit surprised when its not there.
Andrew
next prev parent reply other threads:[~2010-06-23 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 14:20 [B.A.T.M.A.N.] batman-adv debug logging Marek Lindner
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
2010-06-23 14:51 ` Andrew Lunn
2010-06-23 15:02 ` Marek Lindner
2010-06-23 15:12 ` Andrew Lunn
2010-06-23 15:53 ` Marek Lindner
2010-06-23 15:09 ` Andrew Lunn
2010-06-23 15:58 ` Marek Lindner
2010-06-23 16:12 ` Andrew Lunn
2010-06-23 15:17 ` Sven Eckelmann
2010-06-23 16:00 ` Marek Lindner
2010-06-23 15:23 ` Andrew Lunn [this message]
2010-06-23 16:03 ` Marek Lindner
2010-06-23 16:18 ` Andrew Lunn
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: add debug log support Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2010-06-27 0:32 [B.A.T.M.A.N.] batman-adv debug logging (v2) Marek Lindner
2010-06-27 0:33 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100623152359.GL15420@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox