Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs

[Andrew Lunn <andrew@lunn.ch>]

On Wed, Jun 23, 2010 at 05:58:39PM +0200, Marek Lindner wrote:
> On Wednesday 23 June 2010 17:09:13 Andrew Lunn wrote:
> > There will be a ring buffer per mesh. When debugging problems between
> > meshes it is likely both logs will be combined performing a merge
> > based on the timestamp. However at this point you have lost
> > information about which line belongs to which mesh. Could we maybe
> > include the soft interface name in the output?
> 
> Actually, this information is (indirectly) present, since each log file resides 
> inside debugfs/batman_adv/$mesh_if/log. It would be a little bit redundant to 
> add this on every line, wouldn't you agree ? If someone merges 2 mesh files it 
> still can be added ?

It can be done, its just more complex. If it was in the line already, i could
probably just do cat /debugfs/batman_adv/bat?/log | sort | less

Alternatively, batctl could add the interface name after the time
stamp. But there is then no easy way with pipes to combine the output
from two batctls and pass it to sort. So maybe batctl has to do it
all?

> You are right - we could leave it as jiffies. Might be the best solution.

O.K.

	Andrew