From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs
Date: Wed, 23 Jun 2010 18:00:13 +0200 [thread overview]
Message-ID: <201006231800.14434.lindner_marek@yahoo.de> (raw)
In-Reply-To: <201006231717.35877.sven.eckelmann@gmx.de>
On Wednesday 23 June 2010 17:17:27 Sven Eckelmann wrote:
> Can you please change that (at least the 'null' function) from a define to
> an static inline function? Otherwise there are a lot of "unused" warning
> when compiling without debug support.
>
> static inline void bat_dbg(char type __attribute__((unused)),
> struct bat_priv *bat_priv __attribute__((unused)),
> char *fmt __attribute__((unused)), ...)
> { }
Sure, will do.
> To you suggestion to add more information from kernel log to the debug log
> - it seems to be interesting, but we must ensure that those information
> are specific to a mesh device. I will sent a patch which modifies all
> printks later. Maybe we could discuss where it would be a benefit and
> where it is not needed (~54 printks are for discussion).
Yes, sounds good.
Regards,
Marek
next prev parent reply other threads:[~2010-06-23 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 14:20 [B.A.T.M.A.N.] batman-adv debug logging Marek Lindner
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
2010-06-23 14:51 ` Andrew Lunn
2010-06-23 15:02 ` Marek Lindner
2010-06-23 15:12 ` Andrew Lunn
2010-06-23 15:53 ` Marek Lindner
2010-06-23 15:09 ` Andrew Lunn
2010-06-23 15:58 ` Marek Lindner
2010-06-23 16:12 ` Andrew Lunn
2010-06-23 15:17 ` Sven Eckelmann
2010-06-23 16:00 ` Marek Lindner [this message]
2010-06-23 15:23 ` Andrew Lunn
2010-06-23 16:03 ` Marek Lindner
2010-06-23 16:18 ` Andrew Lunn
2010-06-23 14:20 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: add debug log support Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2010-06-27 0:32 [B.A.T.M.A.N.] batman-adv debug logging (v2) Marek Lindner
2010-06-27 0:33 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add routing debug log accessible via debugfs Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006231800.14434.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox