From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: Abraham Arce <abraham.arce.moreno@gmail.com>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <lindner_marek@yahoo.de>,
David Miller <davem@davemloft.net>,
siwu@hrz.tu-chemnitz.de
Subject: Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol
Date: Tue, 20 Jul 2010 20:49:30 +0200 [thread overview]
Message-ID: <201007202049.31530.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <AANLkTim4QSjgC2BbrEJEpefQahbkSgaRPPfJ-N0aPL-E@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1034 bytes --]
Abraham Arce wrote:
> Minor comments...
>
> 1. Is it ok to have a README in drivers directory? why not moving it
> to Documentation/networking?
Thanks, I will check if Documentation/networking is a better place.
> 2. Compilation error, one extra arguments passed
>
> - stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
> + stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
>
> LD kernel/built-in.o
> net/batman-adv/hard-interface.c: In function 'batman_skb_recv':
> net/batman-adv/hard-interface.c:482: error: too many arguments to
> function 'dev_get_stats'
> make[2]: *** [net/batman-adv/hard-interface.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [net/batman-adv] Error 2
> make: *** [net] Error 2
Do you use linux-next or net-next-2.6? Because this is needed to get it
compiled as dev_get_stats was changed some time ago (commit
28172739f0a276eb8d6ca917b3974c2edb036da3), but this is not part of 2.6.35.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-07-20 18:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 14:39 [B.A.T.M.A.N.] [PATCH 0/1] Reviewing batman-adv for net/ Sven Eckelmann
2010-07-16 14:39 ` [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol Sven Eckelmann
2010-07-20 4:26 ` David Miller
2010-07-20 8:28 ` Sven Eckelmann
2010-07-20 16:59 ` David Miller
2010-07-20 17:16 ` Sven Eckelmann
2010-07-20 18:23 ` Marek Lindner
2010-07-20 18:41 ` Abraham Arce
2010-07-20 18:49 ` Sven Eckelmann [this message]
2010-07-20 18:57 ` Ben Hutchings
2010-07-20 19:21 ` Sven Eckelmann
2010-07-16 19:41 ` [B.A.T.M.A.N.] [PATCH 0/1] Reviewing batman-adv for net/ David Miller
2010-07-16 19:47 ` Sven Eckelmann
-- strict thread matches above, loose matches on Subject: below --
2010-06-26 0:14 [B.A.T.M.A.N.] " Sven Eckelmann
2010-06-26 0:14 ` [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007202049.31530.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=abraham.arce.moreno@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox