public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: Don't increase mtu of interface automatically
Date: Sat, 14 Aug 2010 23:32:27 +0200	[thread overview]
Message-ID: <201008142332.28067.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1281820085-13507-9-git-send-email-sven.eckelmann@gmx.de>

On Saturday 14 August 2010 23:08:05 Sven Eckelmann wrote:
> The user usually sets a mtu by hand and don't want to have software to
> change it automatically. This is only needed when we must reduce the mtu
> due to a low mtu of an active slave device, but we should not increase
> it when any other action is made on the system related to the used
> interfaces.

I fear that this might lead to a strange user experience. If the mtu on batX 
wasn't set explicitely but the mtu of an interface used by batman is increased 
while batman uses it the user has to know that he/she now needs to manually 
modify the batX mtu before it becomes effective.

What about a flag which remembers whether the mtu on batX was modified by the 
user. If so, batman-adv does not increase the mtu otherwise we keep the 
current behaviour ?

Regards,
Marek

  reply	other threads:[~2010-08-14 21:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 21:07 [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Create batman_if only on register event Sven Eckelmann
2010-08-14 21:07 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Revert "Adding netfilter-bridge hooks" Sven Eckelmann
2010-08-14 21:07 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: Provide skb_cow_head on kernels prior 2.6.23 Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: Provide old dev_get_by_name for kernel prior 2.6.24 Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: Remove duplicate of attached device name Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: Don't inform about dropped packets in nodebug Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: Don't use net_dev after dev_put Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: Update mtu of bat device by changing mtu of slave device Sven Eckelmann
2010-08-14 21:08 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: Don't increase mtu of interface automatically Sven Eckelmann
2010-08-14 21:32   ` Marek Lindner [this message]
2010-08-15  8:23     ` Sven Eckelmann
2010-08-20 19:23 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Create batman_if only on register event Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008142332.28067.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox