public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Tim <Timbo2001@web.de>, b.a.t.m.a.n@lists.open-mesh.net
Subject: Re: [B.A.T.M.A.N.] Problem openWRT "backfire" and "kmod-batman-adv"
Date: Fri, 20 Aug 2010 17:38:35 +0200	[thread overview]
Message-ID: <201008201738.37057.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201008201644.58520.sven.eckelmann@gmx.de>


[-- Attachment #1.1: Type: Text/Plain, Size: 430 bytes --]

Sven Eckelmann wrote:
> I haven't wrote that code... so it may take a little bit until I feel in
> the right mood to hunt it real down.

Ok, could you please try the attached patch? Just add it to the other patches 
(you can omit 03-... after a successful test. But it may reveal interesting 
information if that wasn't the actual problem). Don't forget to cleanup your 
openwrt build environment.

Best regards,
	Sven

[-- Attachment #1.2: 04-mac_packet_buff_check.patch --]
[-- Type: text/x-patch, Size: 808 bytes --]

diff --git a/hard-interface.c b/hard-interface.c
index 60e8a56..65a4a54 100644
--- a/hard-interface.c
+++ b/hard-interface.c
@@ -129,6 +129,9 @@ static bool hardif_is_iface_up(struct batman_if *batman_if)
 
 static void update_mac_addresses(struct batman_if *batman_if)
 {
+	if (!batman_if || !batman_if->packet_buff)
+		return;
+
 	addr_to_string(batman_if->addr_str, batman_if->net_dev->dev_addr);
 
 	memcpy(((struct batman_packet *)(batman_if->packet_buff))->orig,
@@ -339,6 +342,7 @@ static struct batman_if *hardif_add_interface(struct net_device *net_dev)
 	batman_if->if_num = -1;
 	batman_if->net_dev = net_dev;
 	batman_if->if_status = IF_NOT_IN_USE;
+	batman_if->packet_buff = NULL;
 	INIT_LIST_HEAD(&batman_if->list);
 
 	check_known_mac_addr(batman_if->net_dev->dev_addr);

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-08-20 15:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18  6:42 [B.A.T.M.A.N.] Problem openWRT "backfire" and "kmod-batman-adv" Tim
     [not found] ` <201008201211.51847.sven.eckelmann@gmx.de>
     [not found]   ` <4C6E8B79.7040801@web.de>
2010-08-20 14:44     ` Sven Eckelmann
2010-08-20 15:38       ` Sven Eckelmann [this message]
     [not found]       ` <4C6F5950.8070204@bb.banban.jp>
2010-08-21  6:19         ` Sven Eckelmann
     [not found] <mailman.33.1282337388.934.b.a.t.m.a.n@lists.open-mesh.org>
2010-08-21  8:09 ` Tim
2010-08-21  8:15   ` Sven Eckelmann
  -- strict thread matches above, loose matches on Subject: below --
2010-08-17  9:20 Tim
2010-08-17  9:27 ` Sven Eckelmann
2010-08-17  9:45   ` Tim
2010-08-17  9:51     ` Sven Eckelmann
2010-08-12 18:04 Tim Glaremin
2010-08-13  3:24 ` Sven Eckelmann
2010-08-14 17:26 ` Marek Lindner
2010-08-16 16:51   ` Marek Lindner
2010-08-12 10:14 Tim Glaremin
2010-08-12 10:30 ` Marek Lindner
2010-08-12 10:32 ` Sven Eckelmann
     [not found] <mailman.1.1281002401.15834.b.a.t.m.a.n@lists.open-mesh.org>
2010-08-11 10:47 ` Tim
2010-08-11 11:14   ` Marek Lindner
2010-08-11 11:20   ` Sven Eckelmann
2010-08-11 14:23     ` Tim
2010-08-11 14:52       ` Sven Eckelmann
2010-08-04  9:21 Tim
2010-08-04  9:34 ` Sven Eckelmann
2010-08-04 22:03 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201008201738.37057.sven.eckelmann@gmx.de \
    --to=sven.eckelmann@gmx.de \
    --cc=Timbo2001@web.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.net \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox