From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-ad: automatically add .llseek fop
Date: Thu, 16 Sep 2010 01:44:16 +0200 [thread overview]
Message-ID: <20100915234416.GB21479@lunn.ch> (raw)
In-Reply-To: <1284589835-26617-1-git-send-email-sven.eckelmann@gmx.de>
On Thu, Sep 16, 2010 at 12:30:35AM +0200, Sven Eckelmann wrote:
Hi Sven
...
> The generated code is often incorrectly
> indented and right now contains comments that
> clarify for each added line why a specific
> variant was chosen. In the version that gets
> submitted upstream, the comments will be gone
> and I will manually fix the indentation,
> because there does not seem to be a way to
> do that using coccinelle.
...
> diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c
> index c73ce4a..0b35616 100644
> --- a/batman-adv/bat_debugfs.c
> +++ b/batman-adv/bat_debugfs.c
> @@ -177,6 +177,7 @@ static const struct file_operations log_fops = {
> .release = log_release,
> .read = log_read,
> .poll = log_poll,
> + .llseek = noop_llseek,/* read uses no f_pos */
> };
Would it not be better to wait for the final version which has the
indentation fixed and probably no comment? If you commit this version
now, won't you get a conflict later?
Andrew
next prev parent reply other threads:[~2010-09-15 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 22:30 [B.A.T.M.A.N.] [PATCH] batman-ad: automatically add .llseek fop Sven Eckelmann
2010-09-15 23:44 ` Andrew Lunn [this message]
2010-09-16 8:19 ` Sven Eckelmann
2010-09-16 9:30 ` [B.A.T.M.A.N.] [PATCH] batctl: Mark debugfs files as nonseekable Sven Eckelmann
2010-09-16 9:34 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: " Sven Eckelmann
2010-09-16 12:51 ` [B.A.T.M.A.N.] [PATCH] batctl: " Arnd Bergmann
2010-09-16 13:16 ` [B.A.T.M.A.N.] [PATCH] batman-adv: " Sven Eckelmann
2010-09-18 11:14 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915234416.GB21479@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox