[B.A.T.M.A.N.] [PATCH] batman-adv: Don't dereference unchecked incoming soft_iface

[B.A.T.M.A.N.] [PATCH] batman-adv: Don't dereference unchecked incoming soft_iface

[Sven Eckelmann]

send_packet derefenced forw_packet->if_incoming and checked if
forw_packet->if_incoming is NULL.

This cannot happen, but still makes irritates when reading through the
functions.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
 batman-adv/send.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/batman-adv/send.c b/batman-adv/send.c
index 625a3ba..7097ff0 100644
--- a/batman-adv/send.c
+++ b/batman-adv/send.c
@@ -163,8 +163,8 @@ static void send_packet_to_if(struct forw_packet *forw_packet,
 static void send_packet(struct forw_packet *forw_packet)
 {
 	struct batman_if *batman_if;
-	struct net_device *soft_iface = forw_packet->if_incoming->soft_iface;
-	struct bat_priv *bat_priv = netdev_priv(soft_iface);
+	struct net_device *soft_iface;
+	struct bat_priv *bat_priv;
 	struct batman_packet *batman_packet =
 		(struct batman_packet *)(forw_packet->skb->data);
 	unsigned char directlink = (batman_packet->flags & DIRECTLINK ? 1 : 0);
@@ -175,6 +175,9 @@ static void send_packet(struct forw_packet *forw_packet)
 		return;
 	}
 
+	soft_iface = forw_packet->if_incoming->soft_iface;
+	bat_priv = netdev_priv(soft_iface);
+
 	if (forw_packet->if_incoming->if_status != IF_ACTIVE)
 		return;
 
-- 
1.7.2.3

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Don't dereference unchecked incoming soft_iface

[Marek Lindner]

On Saturday 09 October 2010 02:19:42 Sven Eckelmann wrote:
> send_packet derefenced forw_packet->if_incoming and checked if
> forw_packet->if_incoming is NULL.
> 
> This cannot happen, but still makes irritates when reading through the
> functions.

Applied in revision 1822.

Thanks,
Marek