From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Sun, 10 Oct 2010 14:42:08 +0200 References: <1286685001-15227-1-git-send-email-linus.luessing@web.de> <1286685001-15227-2-git-send-email-linus.luessing@web.de> In-Reply-To: <1286685001-15227-2-git-send-email-linus.luessing@web.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201010101442.08908.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Introduce generic BAT_ATTR_* macros Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Sunday 10 October 2010 06:29:58 Linus L=C3=BCssing wrote: > Additionally, the sysfs entries "aggregate_ogms" and "fragmentation" > get renamed to "aggregation" and "frag" for consistency reasons, they > match the *_enabled parts in bat_priv now. I don't quite understand why you want to rename these names. I like the=20 "aggregate_ogms" as it makes clear what is being aggregated.=20 Please keep in mind that the kernel people won't be happy if we modify the= =20 user space API. Right now, it is less of an issue but once we leave the=20 staging tree it is mostly unchangeable. Regards, Marek