From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 20 Oct 2010 13:57:49 -0700 From: Greg KH Message-ID: <20101020205749.GA9686@kroah.com> References: <1287589664-25447-1-git-send-email-andy.shevchenko@gmail.com> <20101020205115.GA18087@sven-atom.lazhur.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101020205115.GA18087@sven-atom.lazhur.ath.cx> Subject: Re: [B.A.T.M.A.N.] [resend][PATCHv2] staging: batman-adv: remove useless addr_to_string() Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sven Eckelmann Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , The list for a Better Approach To Mobile Ad-hoc Networking , linux-kernel@vger.kernel.org, Simon Wunderlich , Andy Shevchenko , Marek Lindner On Wed, Oct 20, 2010 at 10:51:15PM +0200, Sven Eckelmann wrote: > On Wed, Oct 20, 2010 at 06:47:44PM +0300, Andy Shevchenko wrote: > > Since all *printf() methods in the kernel understand '%pM' modifier the > > conversion to the string is useless beforehand. > > > > Additionally this patch decreases batman_if structure by 20 bytes. > > Thanks for your patch. I have problems with compiling due to other patches in > the queue. I will fix that and recommend it as patch for 2.6.38. What do you mean by this? It applies just fine to my tree, so why can't I take it now? thanks, greg k-h